dqkqd commented on code in PR #18274: URL: https://github.com/apache/datafusion/pull/18274#discussion_r2462250723
########## README.md: ########## @@ -64,7 +64,7 @@ See [use cases] for examples. The following related subprojects target end users DataFusion. "Out of the box," -DataFusion offers [SQL] and [`Dataframe`] APIs, excellent [performance], +DataFusion offers [SQL](docs/source/user-guide/sql) and [Dataframe](docs/source/user-guide/dataframe.md) APIs, excellent [performance], Review Comment: This line was copied from `lib.rs` (original PR: #12418). https://github.com/apache/datafusion/blob/987f333d6d9b659fff4afc102e3fd65b34bae24d/datafusion/core/src/lib.rs#L45-L46 But they were missing the references: https://github.com/apache/datafusion/blob/987f333d6d9b659fff4afc102e3fd65b34bae24d/datafusion/core/src/lib.rs#L60-L61 I think we should keep the original one and add references for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
