comphead commented on code in PR #18268:
URL: https://github.com/apache/datafusion/pull/18268#discussion_r2463200964
##########
datafusion/physical-plan/src/metrics/baseline.rs:
##########
@@ -53,6 +55,16 @@ pub struct BaselineMetrics {
/// output rows: the total output rows
output_rows: Count,
+
+ /// Memory usage of all output batches.
+ ///
+ /// Note: This value may be overestimated. If multiple output `RecordBatch`
+ /// instances share underlying memory buffers, their sizes will be counted
+ /// multiple times.
+ /// Issue: <https://github.com/apache/datafusion/issues/16841>
+ output_bytes: Count,
+ // Remember to update `docs/source/user-guide/metrics.md` when updating
comments
Review Comment:
👍 hope people read it before making changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
