2010YOUY01 commented on code in PR #18297:
URL: https://github.com/apache/datafusion/pull/18297#discussion_r2465553892
##########
datafusion/physical-plan/src/metrics/value.rs:
##########
@@ -546,6 +621,11 @@ impl MetricValue {
.and_then(|ts| ts.timestamp_nanos_opt())
.map(|nanos| nanos as usize)
.unwrap_or(0),
+ // This function is a utility for aggregating metrics, for complex
metric
+ // like `PruningMetrics`, implement it inside `MetricsSet`
directly.
+ Self::PruningMetrics { .. } => {
+ unreachable!()
Review Comment:
updated in
[5d32fff](https://github.com/apache/datafusion/pull/18297/commits/5d32fff05dd2d991060ecfd5c0c9c75dd5766d3a)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
