pepijnve commented on PR #18152: URL: https://github.com/apache/datafusion/pull/18152#issuecomment-3451776870
> are `case_when_with_expr` and `case_when_no_expr` dependent on each other? as it would be easier to review if it could be split to 2 No, they are not interdependent. They do share the `ResultBuilder` logic and the algorithm is 99% the same. The difference is in the base value prelude and the use of compare_eq for the when values. My rust generics skills are not at a point yet where I could figure out a good way to actually share the bulk of the logic. This would probably end up as a case of 'template method'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
