alamb commented on code in PR #18301:
URL: https://github.com/apache/datafusion/pull/18301#discussion_r2466354252
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -810,6 +810,11 @@ impl Accumulator for TrivialFirstValueAccumulator {
// Second index contains is_set flag.
if !self.is_set {
let flags = states[1].as_boolean();
+ debug_assert!(
Review Comment:
I agree with @Jefffrey it would be nice to have this be an internal error
rather than an assert (which results in a panic in debug build and are silently
ignored on release builds)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
