alamb commented on code in PR #18309:
URL: https://github.com/apache/datafusion/pull/18309#discussion_r2467036200
##########
datafusion/datasource/src/source.rs:
##########
@@ -191,6 +192,9 @@ pub trait DataSource: Send + Sync + Debug {
}
}
+pub type ProjectionPushdownResult =
Review Comment:
Can we please document this type (like what the two fields mean)?
I actually think it would be even nicer if this was a real `enum` so we
could document it inline
Perhaps like
```rust
/// Result of evaluating projection pushdown ....
enum ProjectionPushdownResult {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
