benbellick commented on code in PR #17866:
URL: https://github.com/apache/datafusion/pull/17866#discussion_r2467080280
##########
datafusion/substrait/src/extensions.rs:
##########
@@ -113,11 +113,15 @@ impl TryFrom<&Vec<SimpleExtensionDeclaration>> for
Extensions {
}
impl From<Extensions> for Vec<SimpleExtensionDeclaration> {
+ // Silence deprecation warnings for `extension_uri_reference` during the
uri -> urn migration
+ // See: https://github.com/substrait-io/substrait/issues/856
Review Comment:
Yes I am leading the charge on the substrait side of things to do this
migration from uris -> urns. You can find more info
[here](https://github.com/substrait-io/substrait/issues/828).
It may take some time because it will require getting the rest of the
ecosystem off of `uri`s first.
(However, I am aware that datafusion doesn't actually use the extension uri
/ urn information)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
