andygrove commented on code in PR #2650:
URL: https://github.com/apache/datafusion-comet/pull/2650#discussion_r2467141224
##########
spark/src/main/scala/org/apache/comet/serde/CometSort.scala:
##########
@@ -21,12 +21,70 @@ package org.apache.comet.serde
import scala.jdk.CollectionConverters._
+import org.apache.spark.sql.catalyst.expressions.{Ascending, Attribute,
Descending, NullsFirst, NullsLast, SortOrder}
import org.apache.spark.sql.execution.SortExec
+import org.apache.spark.sql.types.{ArrayType, DataType, DataTypes, MapType,
StructType}
import org.apache.comet.{CometConf, ConfigEntry}
import org.apache.comet.CometSparkSessionExtensions.withInfo
import org.apache.comet.serde.OperatorOuterClass.Operator
-import org.apache.comet.serde.QueryPlanSerde.{exprToProto, supportedSortType}
+import org.apache.comet.serde.QueryPlanSerde.{exprToProto,
exprToProtoInternal, supportedSortType}
+
+object CometSortOrder extends CometExpressionSerde[SortOrder] {
+
+ override def getSupportLevel(expr: SortOrder): SupportLevel = {
+
+ def containsFloatingPoint(dt: DataType): Boolean = {
Review Comment:
The method takes a `DataType` parameter, so it seems redundant to include
that in the method name as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
