alamb commented on code in PR #18317:
URL: https://github.com/apache/datafusion/pull/18317#discussion_r2472866442


##########
datafusion/common/src/types/builtin.rs:
##########
@@ -31,6 +33,19 @@ macro_rules! singleton {
     };
 }
 
+macro_rules! singleton_variant {

Review Comment:
   Could you potentially add some documentation here about what is different 
about this macro compared to the others in this module?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to