alamb commented on issue #17379: URL: https://github.com/apache/datafusion/issues/17379#issuecomment-3463885214
> > [@timsaucer](https://github.com/timsaucer) I'd like to tackle Aggregate UDFs and Window UDFs next, as the follow the same pattern > > can both go into one PR or should I do them one by one? > > I try to not make hard rules, so I would say it depends on the scope / size of the review Yeah -- I don't think we have any hard rules However, I would say it is much harder to get larger PRs through the review cycle because they typically require more contiguous time for reviewers, and large block of contiguous time is very hard to find -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
