pepijnve commented on code in PR #18364: URL: https://github.com/apache/datafusion/pull/18364#discussion_r2475491590
########## datafusion/physical-expr/src/expressions/case.rs: ########## @@ -216,10 +216,11 @@ fn filter_array( /// │└─────────┘│ ├─────────┤ ─────────────────────────▶ ├─────────┤ /// │┌─────────┐│ │ None │ │ NULL │ /// ││ C ││ ├─────────┤ ├─────────┤ -/// │├─────────┤│ │ 2 │ │ C │ -/// ││ D ││ ├─────────┤ ├─────────┤ -/// │└─────────┘│ │ 2 │ │ D │ -/// └───────────┘ └─────────┘ └─────────┘ +/// │└─────────┘│ │ 2 │ │ C │ +/// │┌─────────┐│ ├─────────┤ ├─────────┤ +/// ││ D ││ │ 2 │ │ C │ Review Comment: @alamb I hate to be the 'well actually' guy. The diagram was actually correct. An index `n` value means 'take a value from array `n`'. So the first `2` takes the first element from array `2` which is `C`. The second `2` takes the second element which is `D`. The input arrays in the example were the vecs `["A"], ["B"], ["C", "D"]`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
