Dandandan opened a new pull request, #18378: URL: https://github.com/apache/datafusion/pull/18378
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #18376 ## Rationale for this change Performance improvements ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> * Sort the items by hash (and offset) to be able to deduplicate hashes (this introduces some overhead but the hope is this pays off during inserting to the table) * Use insert_unique (https://docs.rs/hashbrown/latest/hashbrown/struct.HashTable.html#method.insert_unique) rather than https://docs.rs/hashbrown/latest/hashbrown/struct.HashTable.html#method.entry for the first entry, which should be quite a bit faster by not having to search for existing items * Keep on using the previous entry for duplicated elements (saving calls to entry for each duplicate) ## Are these changes tested? Yes. existing tests <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
