adriangb commented on issue #18387: URL: https://github.com/apache/datafusion/issues/18387#issuecomment-3468600444
Please use `is_volatile ` instead: https://github.com/apache/datafusion/blob/607325abbebceed7aa327d62409e73917941b66f/datafusion/physical-expr-common/src/physical_expr.rs#L414-L419 https://github.com/apache/datafusion/blob/607325abbebceed7aa327d62409e73917941b66f/datafusion/physical-expr-common/src/physical_expr.rs#L613-L636 We could update the doctoring on `PhysicalExpr::is_volatile_node` to state "you should not call this directly, only implement it. Call [`is_volatile`] instead which handles children expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
