milenkovicm commented on code in PR #1337:
URL:
https://github.com/apache/datafusion-ballista/pull/1337#discussion_r2479219494
##########
ballista/executor/src/executor_server.rs:
##########
@@ -235,7 +239,11 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> ExecutorServer<T,
Ok(scheduler)
} else {
let scheduler_url = format!("http://{scheduler_id}";);
- let connection =
create_grpc_client_connection(scheduler_url).await?;
+ let session_config = (self.executor.config_producer)();
+ let ballista_config = session_config.ballista_config();
+ let grpc_client_config = GrpcClientConfig::from(&ballista_config);
+ let connection =
+ create_grpc_client_connection(scheduler_url,
&grpc_client_config).await?;
Review Comment:
could we have
```rust
create_grpc_client_connection(scheduler_url, &ballista_config.into())
```
it would remove
```rust
let grpc_client_config = GrpcClientConfig::from(&ballista_config);
```
making it a bit easier to read?
##########
ballista/executor/src/executor_process.rs:
##########
@@ -245,8 +249,11 @@ pub async fn start_executor_process(
));
let connect_timeout = opt.scheduler_connect_timeout_seconds as u64;
+ let session_config = (executor.config_producer)();
+ let ballista_config = session_config.ballista_config();
+ let grpc_client_config = GrpcClientConfig::from(&ballista_config);
let connection = if connect_timeout == 0 {
- create_grpc_client_connection(scheduler_url)
+ create_grpc_client_connection(scheduler_url, &grpc_client_config)
Review Comment:
could we have
```rust
create_grpc_client_connection(scheduler_url, &ballista_config.into())
```
it would remove
```rust
let grpc_client_config = GrpcClientConfig::from(&ballista_config);
```
making it a bit easier to read?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
