2010YOUY01 commented on code in PR #18379:
URL: https://github.com/apache/datafusion/pull/18379#discussion_r2480920324
##########
datafusion/physical-plan/src/metrics/value.rs:
##########
@@ -749,17 +749,25 @@ impl MetricValue {
Self::ElapsedCompute(_) => 1,
Self::OutputBytes(_) => 2,
// Other metrics
- Self::PruningMetrics { .. } => 3,
- Self::SpillCount(_) => 4,
- Self::SpilledBytes(_) => 5,
- Self::SpilledRows(_) => 6,
- Self::CurrentMemoryUsage(_) => 7,
- Self::Count { .. } => 8,
- Self::Gauge { .. } => 9,
- Self::Time { .. } => 10,
- Self::StartTimestamp(_) => 11, // show timestamps last
- Self::EndTimestamp(_) => 12,
- Self::Custom { .. } => 13,
+ Self::PruningMetrics { name, .. } => match name.as_ref() {
+ // The order is the same as the actual pruning order: from
+ // coarse-grained to fine-grained pruning levels.
+ "files_ranges_pruned_statistics" => 3,
Review Comment:
Good idea, comments added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
