LiaCastaneda commented on code in PR #18404:
URL: https://github.com/apache/datafusion/pull/18404#discussion_r2482379669
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1025,6 +1031,76 @@ impl ExecutionPlan for AggregateExec {
fn cardinality_effect(&self) -> CardinalityEffect {
CardinalityEffect::LowerEqual
}
+
Review Comment:
Good point, I noticed that `FilterExec` calls
[split_conjunction](https://github.com/apache/datafusion/blob/e65dafe7330f0324b28d9037f4e5a73cf12e99ce/datafusion/expr/src/utils.rs#L953)
which already does this work (for non dynamic filters). So, I think we should
do this mainly for dynamic filters because the expression comes wrapped in a
single physical expression with (potentially) multiple columns depending on
how many `on` key expresions there are, it looks something like :
`DynamicFilterPhysicalExpr([a, b])` <- we should split the conjunctions for
this expression too.
I can make this improvement in this same PR, to make the filter(s) pushdown
more granular.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
