andygrove commented on code in PR #2674: URL: https://github.com/apache/datafusion-comet/pull/2674#discussion_r2482573994
########## docs/source/user-guide/latest/compatibility.md: ########## @@ -101,18 +53,14 @@ Sorting on floating-point data types (or complex types containing floating-point Spark if the data contains both zero and negative zero. This is likely an edge case that is not of concern for many users and sorting on floating-point data can be enabled by setting `spark.comet.expression.SortOrder.allowIncompatible=true`. -There is a known bug with using count(distinct) within aggregate queries, where each NaN value will be counted -separately [#1824](https://github.com/apache/datafusion-comet/issues/1824). - ## Incompatible Expressions -Some Comet native expressions are not 100% compatible with Spark and are disabled by default. These expressions -will fall back to Spark but can be enabled by setting `spark.comet.expression.allowIncompatible=true`. - -## Array Expressions +Expressions that are not 100% Spark-compatible will fall back to Spark by default and can be enabled by setting +`spark.comet.expression.EXPRNAME.allowIncompatible=true`, where `EXPRNAME` is the Spark expression class name. See +the [Comet Supported Expressions Guide](expressions.md) for more information on this configuration setting. -Comet has experimental support for a number of array expressions. These are experimental and currently marked -as incompatible and can be enabled by setting `spark.comet.expression.allowIncompatible=true`. Review Comment: The previous section explains incompatible expressions. There is no need to say anything special about array expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
