alamb commented on code in PR #18406:
URL: https://github.com/apache/datafusion/pull/18406#discussion_r2482647409


##########
datafusion/physical-plan/src/metrics/value.rs:
##########
@@ -430,6 +430,92 @@ impl PruningMetrics {
     }
 }
 
+/// Counters tracking ratio metrics (e.g. matched vs total)
+///
+/// The counters are thread-safe and shared across clones.
+#[derive(Debug, Clone, Default)]
+pub struct RatioMetrics {

Review Comment:
   this is basically the same as Pruned metrics except the display is different 
-- I wonder if we could consolidate the two somehow 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to