andygrove commented on code in PR #2675:
URL: https://github.com/apache/datafusion-comet/pull/2675#discussion_r2483729271
##########
native/core/src/execution/jni_api.rs:
##########
@@ -485,12 +485,14 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_executePlan(
}
let task_ctx = exec_context.session_ctx.task_ctx();
+ // Each Comet native execution corresponds to a single Spark
partition,
+ // so we should always execute partition 0.
let stream = exec_context
.root_op
.as_ref()
.unwrap()
.native_plan
- .execute(partition as usize, task_ctx)?;
+ .execute(0, task_ctx)?;
Review Comment:
This change could impact metrics, and we lack tests in this area. I am
taking a look now to understand this better and see what we can do about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
