2010YOUY01 commented on code in PR #18455:
URL: https://github.com/apache/datafusion/pull/18455#discussion_r2485175033
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -433,6 +433,9 @@ pub(crate) struct GroupedHashAggregateStream {
/// Aggregation-specific metrics
group_by_metrics: GroupByMetrics,
+
+ /// Reduction factor metric (only for partial aggregation)
Review Comment:
```suggestion
/// Reduction factor metric, calculated as `output_rows/input_rows`
(only for partial aggregation)
```
##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -68,6 +68,13 @@ async fn explain_analyze_baseline_metrics() {
"AggregateExec: mode=Partial, gby=[]",
"output_bytes="
);
+
+ assert_metrics!(
+ &formatted,
+ "AggregateExec: mode=Partial, gby=[c1@0 as c1]",
+ "reduction_factor="
Review Comment:
This metric should be stable, we can include the specific expected value
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
