2010YOUY01 opened a new issue, #18467:
URL: https://github.com/apache/datafusion/issues/18467

   ### Is your feature request related to a problem or challenge?
   
   Now `datafusion` CI is using the default set of lint rules in `Clippy`, see 
https://github.com/apache/datafusion/blob/main/ci/scripts/rust_clippy.sh
   
   Here is the `Clippy` doc for lint categories and levels 
https://doc.rust-lang.org/nightly/clippy/
   
   There are several categories not enabled by default, and according to the 
`Clippy` doc, the reasons are they're 'annoying' for general-purpose codebases, 
or they have occasional false positives.
   
   I think DataFusion is both performance and correctness-critical, and it also 
includes substantial complexity. Stricter lint checks could help improve code 
maintainability. We could hand-pick some useful optional lint rules and include 
them in the CI.
   
   Clippy Lints list: https://rust-lang.github.io/rust-clippy/master/index.html
   
   Here are some example lints that are not enabled now, but I think are useful:
   
https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
   https://rust-lang.github.io/rust-clippy/master/index.html#todo
   https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to