Jefffrey commented on code in PR #18443:
URL: https://github.com/apache/datafusion/pull/18443#discussion_r2488415975
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -71,7 +71,7 @@ use sqlparser::tokenizer::Span;
/// use datafusion_sql::unparser::expr_to_sql;
/// let expr = col("a").gt(lit(4)); // form an expression `a > 4`
/// let sql = expr_to_sql(&expr).unwrap(); // convert to ast::Expr
-/// // use the Display impl to convert to SQL text
+/// // use the Display impl to convert
to SQL text
/// assert_eq!(sql.to_string(), "(a > 4)")
Review Comment:
This looks funky; might need to move that display comment to be at the end
of the assert_eq line or otherwise move all comments to their own line (before
their related line of code)
##########
datafusion/sql/tests/cases/diagnostic.rs:
##########
@@ -69,7 +69,9 @@ fn do_query(sql: &'static str) -> Diagnostic {
/// ## Example
///
/// ```rust
-/// let spans = get_spans("SELECT /*whole+left*/speed/*left*/ +
/*right*/10/*right+whole*/ FROM cars");
+/// let spans = get_spans(
+/// "SELECT /*whole+left*/speed/*left*/ + /*right*/10/*right+whole*/ FROM
cars",
+/// );
/// // whole is ^^^^^^^^^^^^^^^^^^^^^^^^^^^
/// // left is ^^^^^
/// // right is ^^
Review Comment:
I think the comments below need to be adjusted as they were referring to the
original format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
