2010YOUY01 commented on code in PR #18481:
URL: https://github.com/apache/datafusion/pull/18481#discussion_r2489885913
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -1108,6 +1128,16 @@ impl NestedLoopJoinStream {
Ok(false) => {
// Left exhausted, transition to FetchingRight
self.left_probe_idx = 0;
+
+ // Selectivity Metric: Update total possibilities for the
batch (left_rows * right_rows)
Review Comment:
```suggestion
// Selectivity Metric: Update total possibilities for the
batch (left_rows * right_rows)
// If memory-limited execution is implemented, this logic
must be updated accordingly.
```
I think we have to go for the complex approach if
https://github.com/apache/datafusion/blob/db5f47c88afb009fa150f282be4c37a136221d88/datafusion/physical-plan/src/joins/nested_loop_join.rs#L159
is implemented, let's add a note for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
