andygrove commented on code in PR #2682:
URL: https://github.com/apache/datafusion-comet/pull/2682#discussion_r2492160958
##########
fuzz-testing/src/main/scala/org/apache/comet/fuzz/Meta.scala:
##########
@@ -65,8 +65,12 @@ object Meta {
(DataTypes.StringType, 0.2),
(DataTypes.BinaryType, 0.1))
- private def createFunctionWithInputTypes(name: String, inputs:
Seq[SparkType]): Function = {
- Function(name, Seq(FunctionSignature(inputs)))
+ private def createFunctionWithInputTypes(
+ name: String,
+ inputs: Seq[SparkType],
+ varArgs: Boolean = false): Function = {
+ Function(name, Seq(FunctionSignature(inputs, varArgs)))
Review Comment:
Should there be a check here to ensure that the `inputs` array has a single
element if `varArgs == true`? See my other comment which is related to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
