zhuqi-lucas commented on PR #18492:
URL: https://github.com/apache/datafusion/pull/18492#issuecomment-3489901524
> > And, sqllogictest is the member of datafusion, it will default to
encryption when we use datafusion.
>
> Could you help me understand this point?
Sure, let me clarify that point, correct me if i am wrong, but this PR works
in our production now, it fixed the problem. Our use case is to use workspace
which including the datafusion default features.
Because datafusion-sqllogictest is part of the same workspace, and in its
Cargo.toml it depends on datafusion with:
```rust
datafusion = { workspace = true, default-features = true, features =
["avro", "parquet_encryption"] }
```
Cargo feature unification means that if any crate in the workspace enables a
feature for a dependency, that feature becomes enabled for the entire build. So
even if users import datafusion separately, as long as they depend on this
workspace, the parquet_encryption feature is still activated through
sqllogictest.
In other words, sqllogictest enabling parquet_encryption causes datafusion
to be compiled with encryption enabled by default for anyone building the
workspace.
That’s why it appears as if encryption is "enabled by default" from the user
perspective.
This PR changes the default behavior so that encryption is only included
when explicitly requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
