Dandandan commented on code in PR #16905: URL: https://github.com/apache/datafusion/pull/16905#discussion_r2497934822
########## datafusion/sqllogictest/test_files/window.slt: ########## @@ -3246,8 +3246,8 @@ logical_plan 03)----WindowAggr: windowExpr=[[sum(aggregate_test_100.c9) ORDER BY [aggregate_test_100.c9 DESC NULLS FIRST] RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW]] 04)------TableScan: aggregate_test_100 projection=[c9] physical_plan -01)ProjectionExec: expr=[c9@0 as c9, sum(aggregate_test_100.c9) ORDER BY [aggregate_test_100.c9 DESC NULLS FIRST] RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW@1 as sum1] -02)--GlobalLimitExec: skip=0, fetch=5 +01)PartialSortExec: TopK(fetch=5), expr=[sum1@1 ASC NULLS LAST, c9@0 DESC], common_prefix_length=[1] Review Comment: This looks more work than the existing plan (only a limit)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
