mbutrovich commented on code in PR #2695:
URL: https://github.com/apache/datafusion-comet/pull/2695#discussion_r2499959318
##########
spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala:
##########
@@ -71,8 +71,20 @@ class CometFuzzTestSuite extends CometFuzzTestBase {
// Construct the string for the default value based on the column type.
val defaultValueString = defaultValueType match {
// These explicit type definitions for TINYINT, SMALLINT, FLOAT,
DOUBLE, and DATE are only needed for 3.4.
- case "TINYINT" | "SMALLINT" | "FLOAT" | "DOUBLE" =>
+ case "TINYINT" | "SMALLINT" =>
s"$defaultValueType(${defaultValueRow.get(0)})"
+ case "FLOAT" =>
+ if (Float.NaN.equals(defaultValueRow.get(0))) {
+ "FLOAT('NaN')"
Review Comment:
Is this string literal defined somewhere so we don't have to maintain it
here? I don't imagine it'll change, but still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
