pepijnve commented on PR #17813: URL: https://github.com/apache/datafusion/pull/17813#issuecomment-3499430279
In the meantime I spotted this in the documentation ``` /// A flag to indicate whether the physical planner should validate that the rule will not /// change the schema of the plan after the rewriting. /// Some of the optimization rules might change the nullable properties of the schema /// and should disable the schema check. fn schema_check(&self) -> bool; ``` So nullability changes are actually already allowed by the optimizer and the fix is to disable schema checks entirely. The relaxed schema check that allows restricting nullability seems fine then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
