corasaurus-hex commented on code in PR #18457:
URL: https://github.com/apache/datafusion/pull/18457#discussion_r2501258885
##########
datafusion/datasource-arrow/src/file_format.rs:
##########
@@ -175,10 +182,39 @@ impl FileFormat for ArrowFormat {
async fn create_physical_plan(
&self,
- _state: &dyn Session,
+ state: &dyn Session,
conf: FileScanConfig,
) -> Result<Arc<dyn ExecutionPlan>> {
- let source = Arc::new(ArrowSource::default());
+ let is_stream_format = if let Some(first_group) =
conf.file_groups.first() {
Review Comment:
fixed! I opted to go with a positive check for whether it's in the arrow
file format. Future steps that perform the actual parsing of the file should
catch if it's not in the arrow stream format either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
