2010YOUY01 commented on code in PR #18491:
URL: https://github.com/apache/datafusion/pull/18491#discussion_r2501609794
##########
datafusion/core/tests/sql/mod.rs:
##########
@@ -40,18 +40,24 @@ use std::io::Write;
use std::path::PathBuf;
use tempfile::TempDir;
-/// A macro to assert that some particular line contains two substrings
+/// A macro to assert that some particular line contains the given substrings
Review Comment:
👍🏼
##########
datafusion/physical-plan/src/metrics/baseline.rs:
##########
@@ -86,6 +89,9 @@ impl BaselineMetrics {
output_bytes: MetricBuilder::new(metrics)
.with_type(super::MetricType::SUMMARY)
.output_bytes(partition),
+ output_batches: MetricBuilder::new(metrics)
+ .with_type(super::MetricType::SUMMARY)
Review Comment:
```suggestion
.with_type(super::MetricType::DEV)
```
Personally I think it is a bit verbose for `summary` level 🤔
##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -61,12 +61,9 @@ async fn explain_analyze_baseline_metrics() {
assert_metrics!(
&formatted,
"AggregateExec: mode=Partial, gby=[]",
- "metrics=[output_rows=3, elapsed_compute="
- );
- assert_metrics!(
- &formatted,
- "AggregateExec: mode=Partial, gby=[]",
- "output_bytes="
+ "metrics=[output_rows=3, elapsed_compute=",
+ "output_bytes=",
+ "output_batches="
Review Comment:
The output_batches expected value should be stable, let's add it here like
`output_batches=1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
