Gohlub commented on PR #18520: URL: https://github.com/apache/datafusion/pull/18520#issuecomment-3503502547
> > Yes, I ran cargo test --package datafusion-expr and all but one passed (based on my observations, it seems to not be related to my changes). The failed test is: > > test expr_rewriter::order_by::test::rewrite_sort_cols_by_agg_alias ... FAILED > > Thank you for working on it! I think the failure is due to the public API change. I have updated the write up #18503 instruction section, you can find details there. (TLDR: don't fix for public functions like `lit`, and suppress the clippy error with `#[expect(clippy::needless_pass_by_value)]`) > > BTW I suggest to turn off the lint for test modules (see above link) and start over, it seems there are only around 2 changes required for this crate. Thank you for the feedback! I'll close this PR and open a new one and start over (for the sake of clarity). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
