0xPoe commented on code in PR #18534:
URL: https://github.com/apache/datafusion/pull/18534#discussion_r2504756278
##########
datafusion/physical-plan/src/windows/window_agg_exec.rs:
##########
@@ -159,8 +159,8 @@ impl WindowAggExec {
}
}
- fn statistics_inner(&self) -> Result<Statistics> {
- let input_stat = self.input.partition_statistics(None)?;
+ fn statistics_inner(&self, partition: Option<usize>) -> Result<Statistics>
{
Review Comment:
We may want to move the code directly into the partition_statistics and
remove this inner function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
