alamb commented on code in PR #18372: URL: https://github.com/apache/datafusion/pull/18372#discussion_r2506878163
########## docs/source/library-user-guide/extending-operators.md: ########## @@ -19,22 +19,21 @@ # Extending DataFusion's operators: custom LogicalPlan and Execution Plans -DataFusion supports extension of operators by transforming logical plan and execution plan through customized [optimizer rules](https://docs.rs/datafusion/latest/datafusion/optimizer/trait.OptimizerRule.html). This section will use the µWheel project to illustrate such capabilities. +DataFusion supports extension of operators by transforming logical plan and execution plan through customized [optimizer rules](https://docs.rs/datafusion/latest/datafusion/optimizer/trait.OptimizerRule.html). This section demonstrates these capabilities through two examples. -## About DataFusion µWheel +## Example 1: DataFusion µWheel [DataFusion µWheel](https://github.com/uwheel/datafusion-uwheel/tree/main) is a native DataFusion optimizer which improves query performance for time-based analytics through fast temporal aggregation and pruning using custom indices. The integration of µWheel into DataFusion is a joint effort with the DataFusion community. ### Optimizing Logical Plan The `rewrite` function transforms logical plans by identifying temporal patterns and aggregation functions that match the stored wheel indices. When match is found, it queries the corresponding index to retrieve pre-computed aggregate values, stores these results in a [MemTable](https://docs.rs/datafusion/latest/datafusion/datasource/memory/struct.MemTable.html), and returns as a new `LogicalPlan::TableScan`. If no match is found, the original plan proceeds unchanged through DataFusion's standard execution path. - ```rust,ignore fn rewrite( &self, plan: LogicalPlan, _config: &dyn OptimizerConfig, -) -> Result<Transformed<LogicalPlan>> { +) -> Result<Transformed> { Review Comment: I am pretty sure this is an incorrect change -- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
