andygrove commented on code in PR #2735:
URL: https://github.com/apache/datafusion-comet/pull/2735#discussion_r2507047074
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -534,6 +534,14 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
s
}
+ case op: LocalTableScanExec if
CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.get(conf) =>
+ val nativeOp = QueryPlanSerde.operator2Proto(op)
+ val cometOp = CometLocalTableScanExec(op, op.rows, op.output)
+ CometScanWrapper(nativeOp.get, cometOp)
+
+ case op: LocalTableScanExec if
!CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.get(conf) =>
+ withInfo(op, "LocalTableScan is not enabled")
Review Comment:
These could be combined into a single match arm.
```suggestion
case op: LocalTableScanExec =>
if (CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.get(conf)) {
val nativeOp = QueryPlanSerde.operator2Proto(op)
val cometOp = CometLocalTableScanExec(op, op.rows, op.output)
CometScanWrapper(nativeOp.get, cometOp)
} else {
withInfo(op, "LocalTableScan is not enabled")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
