timsaucer commented on PR #18568: URL: https://github.com/apache/datafusion/pull/18568#issuecomment-3508558749
Blocking issue: We have places in the code like `get_scalar_value_from_args()` that will attempt to downcast `Arc<dyn PhysicalExpr>` into something like `Literal`. These fail when it is coming through FFI. We *could* special case Literal and maybe some others but it feels like this may be a long tail of special casing. It *may* be better to go back to using proto on the physical expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
