EmilyMatt commented on code in PR #18446:
URL: https://github.com/apache/datafusion/pull/18446#discussion_r2510910053
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -249,6 +309,28 @@ mod tests {
use super::*;
use arrow::array::Int32Array;
+ #[test]
+ fn into_array_of_size() {
+ // Array case
+ let arr = make_array(1, 3);
+ let arr_columnar_value = ColumnarValue::Array(Arc::clone(&arr));
+ assert_eq!(&arr_columnar_value.into_array_of_size(3).unwrap(), &arr);
+
+ // Scalar case
+ let scalar_columnar_value =
ColumnarValue::Scalar(ScalarValue::Int32(Some(42)));
+ let expected_array = make_array(42, 100);
+ assert_eq!(
+ &scalar_columnar_value.into_array_of_size(100).unwrap(),
+ &expected_array
+ );
+
+ // Array case with wrong size
+ let arr = make_array(1, 3);
+ let arr_columnar_value = ColumnarValue::Array(Arc::clone(&arr));
+ let result = arr_columnar_value.into_array_of_size(5);
+ assert!(result.is_err());
Review Comment:
Done
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -135,6 +135,36 @@ impl ColumnarValue {
/// number of rows. [`Self::Scalar`] is converted by repeating the same
/// scalar multiple times which is not as efficient as handling the scalar
/// directly.
+ /// This validates that [`Self::Array`], if it exists, has the expected
length.
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
