alamb commented on PR #16916: URL: https://github.com/apache/datafusion/pull/16916#issuecomment-3512786374
> Hi @alamb , > > When working on enabling CI check to ensure consistent formatting, I found there is a conflict. The result of `cargo fmt` cannot pass this command `cargo +nightly fmt --all -- --check --config format_code_in_doc_comments=true`. After running `cargo +nightly fmt --all -- --config format_code_in_doc_comments=true`, the result will not pass `cargo fmt --all -- --check`. > > It seems that these two actions have different rules about trailing spaces after `//!` and `///`. > > How to reproduce > > 1. cargo fmt --all → passes > 2. cargo +nightly fmt --all -- --check --config format_code_in_doc_comments=true → fails > 3. cargo +nightly fmt --all -- --config format_code_in_doc_comments=true → fixes it > 4. cargo fmt --all -- --check → fails again Thanks @CuteChuanChuan I would think that we would have to use the same version of `cargo fmt` -- `cargo +nightly fmt` and `cargo fmt` run different version of `cargo-fmt` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
