iffyio commented on code in PR #2090:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2090#discussion_r2513366319
##########
tests/sqlparser_postgres.rs:
##########
@@ -5140,6 +5140,10 @@ fn test_simple_postgres_insert_with_alias() {
assert_eq!(
statement,
Statement::Insert(Insert {
+ insert_token: AttachedToken(TokenWithSpan {
+ token: Token::make_keyword("INSERT"),
+ span: Span::new((1, 1).into(), (1, 7).into()),
+ }),
Review Comment:
```suggestion
insert_token: AttachedToken::empty(),
```
I think for these we can use an empty token - since token comparisons are
ignored in tests. Same for the other files
##########
src/ast/spans.rs:
##########
@@ -2535,4 +2542,22 @@ ALTER TABLE users
assert_eq!(stmt_span.start, (2, 13).into());
assert_eq!(stmt_span.end, (4, 11).into());
}
+
+ #[test]
+ fn test_update_statement_span() {
Review Comment:
Can we add similar test for `DELETE`, `INSERT`, `REPLACE` statements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
