alamb commented on PR #18619: URL: https://github.com/apache/datafusion/pull/18619#issuecomment-3518293813
Marking as draft I second @Jefffrey 's commentary. @chenkovsky your contributions are appreciated -- but they would be more appreciated (and more likely to get reviews faster / more usefully) if you made them easier to review As @Jefffrey says, one part of making the code easier to review is a good description so reviewers don't have to research the background for the proposal Other things that can help: 1. Breaking larger PRs into smaller ones (not relevant for this PR) 2. Using inline comments to draw our attention to important parts of the PR that might not be obvious from the body 3. Ensuring the code changes are well commented and tested (specifically I often look at the tests first so I know what the code is doing, so if it is not clear from the tests what the intent of a PR is, that will make it harder to review) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
