Viicos commented on code in PR #2077:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2077#discussion_r2515603106
##########
src/tokenizer.rs:
##########
@@ -449,29 +449,6 @@ impl Word {
}
}
-#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
-#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
-#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
-pub enum Whitespace {
- Space,
- Newline,
- Tab,
- SingleLineComment { comment: String, prefix: String },
- MultiLineComment(String),
-}
Review Comment:
I see; I still think it would be important for any kind of comment to be
preserved as tokens (my use case is related to completions, but it can be also
useful if you want to implement a formatting mechanism that preserves comments,
or if a comment can be used to e.g. specify a linter directive -- presumably
would be relevant for interstitial comments as well).
I commented some thoughts on this PR ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
