iffyio commented on code in PR #2097:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2097#discussion_r2518259138
##########
src/parser/mod.rs:
##########
@@ -51,13 +51,14 @@ mod alter;
pub enum ParserError {
TokenizerError(String),
ParserError(String),
+ SpannedParserError(String, Span),
Review Comment:
I'm thinking introducing a new error type would be confusing since it would
duplicate the `ParserError` variant. Can we instead change the `ParserError`
variant to e.g?
```rust
ParserError(ParseError {
message: String,
span: Span
})
```
We can also mention in the documentation of `span` that it returns
`[Span::empty]` when the information is unknown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
