Standing-Man commented on code in PR #18640:
URL: https://github.com/apache/datafusion/pull/18640#discussion_r2520652600
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -2377,16 +2377,16 @@ impl DataFrame {
/// .read_csv("tests/data/example.csv", CsvReadOptions::new())
/// .await?;
/// // Fill nulls in only columns "a" and "c":
- /// let df = df.fill_null(ScalarValue::from(0), vec!["a".to_owned(),
"c".to_owned()])?;
+ /// let df = df.fill_null(&ScalarValue::from(0), &["a".to_owned(),
"c".to_owned()])?;
/// // Fill nulls across all columns:
- /// let df = df.fill_null(ScalarValue::from(0), vec![])?;
+ /// let df = df.fill_null(&ScalarValue::from(0), &[])?;
/// # Ok(())
/// # }
/// ```
pub fn fill_null(
&self,
- value: ScalarValue,
- columns: Vec<String>,
+ value: &ScalarValue,
Review Comment:
Thank you, I've added clippy::allow to the public functions
(`optimize_physical_plan` and `fill_null`) on new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
