Tim-53 commented on code in PR #18663:
URL: https://github.com/apache/datafusion/pull/18663#discussion_r2521198764
##########
datafusion/functions-aggregate/src/approx_percentile_cont.rs:
##########
@@ -167,7 +167,7 @@ impl ApproxPercentileCont {
args: AccumulatorArgs,
) -> Result<ApproxPercentileAccumulator> {
let percentile =
- validate_percentile_expr(&args.exprs[1],
"APPROX_PERCENTILE_CONT")?;
+ validate_percentile_expr(&args.exprs[1],
"APPROX_PERCENTILE_CONT")?[0];
Review Comment:
This change was made purely to make `percentile_cont` compile and behave
correctly.
I'm not yet sure whether `approx_percentile_cont` should be enhanced in the
same way; that can be addressed in a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
