alamb commented on code in PR #18654:
URL: https://github.com/apache/datafusion/pull/18654#discussion_r2524609629
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -1738,42 +1746,42 @@ impl From<ScalarValue> for NullableInterval {
}
impl NullableInterval {
- /// An interval that only contains 'false'.
+ /// An interval containing only the 'false' truth value.
+ /// This interval is semantically equivalent to [Interval::FALSE].
pub const FALSE: Self = NullableInterval::NotNull {
- values: Interval::CERTAINLY_FALSE,
+ values: Interval::FALSE,
Review Comment:
this now has a very nice symmetry to it
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -333,33 +333,27 @@ impl PhysicalExpr for BinaryExpr {
let right_interval = children[1];
if self.op.eq(&Operator::And) {
- if interval.eq(&Interval::CERTAINLY_TRUE) {
+ if interval.eq(&Interval::TRUE) {
Review Comment:
I think these changes really make the code easier to read and understand --
thank you @pepijnve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
