timsaucer opened a new pull request, #18680: URL: https://github.com/apache/datafusion/pull/18680
## Which issue does this PR close? - Addresses part of https://github.com/apache/datafusion/issues/18671 but does not close it. Note: This is based on top of https://github.com/apache/datafusion/pull/18679. I will rebase after that one merges to remove the parts of the code that are not relevant to this PR. ## Rationale for this change We are currently passing around a `SessionConfig` and then creating a `SessionContext` in the FFI layer in two places of `TableProvider`, `scan` and `insert_into`. This forces us to create a new `SessionContext` which does not have all of the registered functions and other features during these operations. Additionally it leads to library size bloat. This PR implements a FFI `Session`. Additionally, after this PR we can remove `datafusion` core crate from `datafusion-ffi`. That will be a different PR since it is large but mostly changing around `use` statements. ## What changes are included in this PR? - Implement `FFI_Session` - Update `FFI_TableProvider` to use `FFI_Session` for its operations. ## Are these changes tested? Tested with unit tests and against `datafusion-python`. ## Are there any user-facing changes? These should be essentially transparent to the user, but it is a breaking FFI API change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
