danielhumanmod commented on PR #1309:
URL: 
https://github.com/apache/datafusion-ballista/pull/1309#issuecomment-3531493946

   > I agree with you let's finish explain first.
   > 
   > I had a quick look at internals but I never finished my investigation how 
to add callback in a better way, will try to do it before you finish explain
   
   Hey @milenkovicm I have updated our `EXPLAIN` implementation based on our 
prev discussion. Basically I follow this exec rewrite: 
   
   ```
   Previous:
        ExplainExec
   After:
        CoalescePartitionsExec
          └─ ProjectionExec: expr=[list_type -> plan_type, list_plan -> plan]
              └─ UnnestExec
                   └─ ProjectionExec: expr=[list_type, list_plan]
                        └─ PlaceholderRowExec 
   ```
   which produces a table like this:
   ```
   | plan_type        | plan            |
   |------------------|-----------------|
   | logical_plan     | logical_txt     |
   | physical_plan    | physical_txt    |
   | distributed_plan | distributed_txt |
   ```
   
   Appreciate any feedback on this! And I’m also happy to help with the 
callback part — just let me know the direction or any context I should be aware 
of, and I can dig into it as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to