martin-g commented on code in PR #2775: URL: https://github.com/apache/datafusion-comet/pull/2775#discussion_r2526605714
########## docs/source/user-guide/latest/configs.md: ########## @@ -81,7 +81,7 @@ These settings can be used to determine which parts of the plan are accelerated | `spark.comet.explain.native.enabled` | When this setting is enabled, Comet will provide a tree representation of the native query plan before execution and again after execution, with metrics. | false | | `spark.comet.explain.rules` | When this setting is enabled, Comet will log all plan transformations performed in physical optimizer rules. Default: false | false | | `spark.comet.explainFallback.enabled` | When this setting is enabled, Comet will provide logging explaining the reason(s) why a query stage cannot be executed natively. Set this to false to reduce the amount of logging. | false | -| `spark.comet.logFallbackReasons.enabled` | When this setting is enabled, Comet will log warnings for all fallback reasons. Can be overridden by environment variable `ENABLE_COMET_LOG_FALLBACK_REASONS`. | false | +| `spark.comet.logFallbackReasons.enabled` | When this setting is enabled, Comet will log warnings for all fallback reasons. Can be overridden by environment variable `ENABLE_COMET_LOG_FALLBACK_REASONS`. | true | Review Comment: https://github.com/andygrove/datafusion-comet/blob/8e97fd179be5733dad328ba7dac3308bd0a319f7/common/src/main/scala/org/apache/comet/CometConf.scala#L502 says that the default is `false` ########## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ########## Review Comment: somehow related to these changes: ```suggestion CometConf.getExprAllowIncompatConfigKey(classOf[Cast]) -> "true", ``` ########## docs/source/user-guide/latest/configs.md: ########## @@ -81,7 +81,7 @@ These settings can be used to determine which parts of the plan are accelerated | `spark.comet.explain.native.enabled` | When this setting is enabled, Comet will provide a tree representation of the native query plan before execution and again after execution, with metrics. | false | | `spark.comet.explain.rules` | When this setting is enabled, Comet will log all plan transformations performed in physical optimizer rules. Default: false | false | | `spark.comet.explainFallback.enabled` | When this setting is enabled, Comet will provide logging explaining the reason(s) why a query stage cannot be executed natively. Set this to false to reduce the amount of logging. | false | -| `spark.comet.logFallbackReasons.enabled` | When this setting is enabled, Comet will log warnings for all fallback reasons. Can be overridden by environment variable `ENABLE_COMET_LOG_FALLBACK_REASONS`. | false | +| `spark.comet.logFallbackReasons.enabled` | When this setting is enabled, Comet will log warnings for all fallback reasons. Can be overridden by environment variable `ENABLE_COMET_LOG_FALLBACK_REASONS`. | true | Review Comment: ```suggestion | `spark.comet.logFallbackReasons.enabled` | When this setting is enabled, Comet will log warnings for all fallback reasons. It can be overridden by environment variable `ENABLE_COMET_LOG_FALLBACK_REASONS`. | true | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
