kumarUjjawal commented on code in PR #18700:
URL: https://github.com/apache/datafusion/pull/18700#discussion_r2527755995
##########
datafusion/functions/src/core/greatest.rs:
##########
@@ -113,11 +113,10 @@ impl GreatestLeastOperator for GreatestFunc {
let cmp = make_comparator(lhs, rhs, SORT_OPTIONS)?;
- if lhs.len() != rhs.len() {
- return internal_err!(
- "All arrays should have the same length for greatest
comparison"
- );
- }
+ assert_or_internal_err!(
+ lhs.len() == rhs.len(),
+ "All arrays should have the same length for greatest comparison"
+ );
Review Comment:
Changed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
