Jefffrey commented on code in PR #18715:
URL: https://github.com/apache/datafusion/pull/18715#discussion_r2529472017
##########
datafusion/proto/src/physical_plan/to_proto.rs:
##########
@@ -53,7 +53,7 @@ use crate::protobuf::{
use super::PhysicalExtensionCodec;
pub fn serialize_physical_aggr_expr(
- aggr_expr: Arc<AggregateFunctionExpr>,
+ aggr_expr: &Arc<AggregateFunctionExpr>,
Review Comment:
I believe this would be a breaking change to the API so we shouldn't change
it, just suppress it with `#[expect(clippy::needless_pass_by_value)]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
