kumarUjjawal commented on code in PR #18732:
URL: https://github.com/apache/datafusion/pull/18732#discussion_r2529775422
##########
datafusion/physical-optimizer/src/enforce_sorting/replace_with_order_preserving_variants.rs:
##########
@@ -139,16 +139,21 @@ pub fn plan_with_order_preserving_variants(
if let Some(ordering) = child.output_ordering() {
let mut fetch = fetch;
if let Some(coalesce_fetch) = sort_input.plan.fetch() {
- if let Some(sort_fetch) = fetch {
- if coalesce_fetch < sort_fetch {
- return internal_err!(
- "CoalescePartitionsExec fetch [{:?}] should be
greater than or equal to SortExec fetch [{:?}]", coalesce_fetch, sort_fetch
+ fetch = match fetch {
Review Comment:
I was a little unsure about this block, would like a feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
